I just can't get other how awful this code is.
It's like every worst pratice possible in one place.
And it get worst and worst everytime you reread it 😐
Everything is a pure disaster.
Also you can probably execute whatever sql you want so it's a free for all database 😐
That the worst part for me. By far.
At a "code logic" level or reading, that statement of "if anything makes sense, then we're wrong" is what gets the most stuck into my eye, but I also feel it's the right epitaph for that project X-)
- selecting the whole table then looping through it
- with plain text passwords
- via an interface which takes SQL queries as the input
- ON THE BROWSER
- Using prop on the cookie to store login status
- that "if" statement...
- and most heinous of all - inconsistent quotes for strings 😋
@bram Sometimes you struggle with imposter syndrome. And sometimes you find stuff like this.
I might add unnecessarily complex code, I might do security-check client-side, I might store user credentials in unencrypted plaintext, I might expose of all that data to any random visitor, and I might even expose a free sql access to any client, but at least I know that $.click() is deprecated in favour of $.on().
I feel like a real trustworthy professional now 🕶
@bram L’API qui accepte n’importe quel SQL. Tous les utilisateurs/mdp chargés dans le navigateur. Les mots de passe en clair. Le "true" === "true" return false. Cette boucle digne d’un code C. Le cookie de connexion.
how is it even possible to be so wrong on so many levels
@bram i left my role of 3 years in july and am struggling to find something else (I was looking for a while before I left too). I've had really positive responses from a few companies that always boiled down to "we'd love to talk to you in X months" or whatever. kinda sucks a lot
This is an open mastodon instance for social justice activists, LGBTQIA+ people, and people who are aware of such subjects and care about them.
See the Goals, rules, and technical details for more information